Skip to content

Add doi to publication page#5133

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
the-library-code:doi-unifification
Mar 2, 2026
Merged

Add doi to publication page#5133
tdonohue merged 1 commit intoDSpace:mainfrom
the-library-code:doi-unifification

Conversation

@strawburster
Copy link
Contributor

@strawburster strawburster commented Feb 20, 2026 •
edited
Loading

References

Required: DSpace/DSpace#11545
Related to: DSpace/DSpace#9901

Provided with <3 by The Library Code

Description

Add the DOI metadata field to the publication page.

Instructions for Reviewers

Please see any publication page with a metadata property 'dc.identifier.doi' and verify that it is listed on the left under authors and publishers.

List of changes in this PR:

  • Add new generic-item-page-field to publication.component.html to display the DOI
    The urlRegex attribute is used to interpret ^https?:// dois as a link.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 20, 2026
@EikLoe
Copy link
Member

EikLoe commented Feb 24, 2026

Hi @strawburster
Thanks for the PR. It could be interesting to add the DOI to the untyped-item-page as well. What do you think?

@tdonohue tdonohue requested a review from artlowel February 26, 2026 15:31
@tdonohue tdonohue moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release Feb 26, 2026
artlowel
artlowel approved these changes Feb 26, 2026
View reviewed changes
Copy link
Member

@artlowel artlowel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @strawburster!

The code looks good and it works.

I agree with @EikLoe's suggestion that it would be good to add this to untyped item pages as well

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Feb 26, 2026
@strawburster
Add doi to publication page and untyped-item page
2193183 
Fall back to 'hasversion' if necessary
@strawburster
Copy link
Contributor Author

strawburster commented Mar 2, 2026

I added the same component to the untyped item template, but I actually don't know where that component is being used, so I haven't tested it. Sorry, I still am a little new to this project.

@MMilosz
Copy link
Contributor

MMilosz commented Mar 2, 2026

I added the same component to the untyped item template, but I actually don't know where that component is being used, so I haven't tested it. Sorry, I still am a little new to this project.

@strawburster the untyped item is any item that does NOT have dspace.entity.type metadata set (by default, it's inherited from collection's dspace.entity.type, if collection has one)

Also, I confirm it's working well for untyped items

image

@MMilosz MMilosz self-requested a review March 2, 2026 15:00
@tdonohue
Copy link
Member

tdonohue commented Mar 2, 2026

Merging as this is at +2. Thanks @strawburster !

@tdonohue tdonohue merged commit 0258439 into DSpace:main Mar 2, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Mar 2, 2026
@tdonohue tdonohue added this to the 10.0 milestone Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artlowel artlowel artlowel approved these changes

+1 more reviewer

@MMilosz MMilosz MMilosz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@strawburster strawburster

Labels

identifiers: DOIs improvement new feature

Projects

DSpace 10.0 Release
Status: ✅ Done

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@strawburster @EikLoe @MMilosz @tdonohue @artlowel